dmvk commented on code in PR #24021:
URL: https://github.com/apache/flink/pull/24021#discussion_r1453772437
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -177,6 +177,103 @@ public class AdaptiveScheduler
private static final Logger LOG =
LoggerFactory.getLogger(AdaptiveScheduler.class);
+ /**
+ * Consolidated settings for the adaptive scheduler. This class is used to
avoid passing around
+ * multiple config options.
+ */
+ public static class Settings {
Review Comment:
I don't see where the SLOT_REQUEST_TIMEOUT is used by AS, can you please
give me a pointer on what you have in mind?
For MIN_PARALLELISM_INCREASE, I've intentionally kept that local to
`EnforceMinimalIncreaseRescalingController`. Ultimately the interface should be
swappable (that's why it's behind an interface and constructor accepts
configuration).
OT: I'm also starting to doubt we still need it. We've talked about it
briefly with @zentol and it mostly seems to be a leftover from early work on
reactive mode.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -177,6 +177,103 @@ public class AdaptiveScheduler
private static final Logger LOG =
LoggerFactory.getLogger(AdaptiveScheduler.class);
+ /**
+ * Consolidated settings for the adaptive scheduler. This class is used to
avoid passing around
+ * multiple config options.
+ */
+ public static class Settings {
+
+ public static Settings of(Configuration configuration) {
+ final SchedulerExecutionMode executionMode =
+ configuration.get(JobManagerOptions.SCHEDULER_MODE);
+ Duration allocationTimeoutDefault =
+ JobManagerOptions.RESOURCE_WAIT_TIMEOUT.defaultValue();
+ Duration stabilizationTimeoutDefault =
+
JobManagerOptions.RESOURCE_STABILIZATION_TIMEOUT.defaultValue();
+ if (executionMode == SchedulerExecutionMode.REACTIVE) {
+ allocationTimeoutDefault = Duration.ofMillis(-1);
+ stabilizationTimeoutDefault = Duration.ZERO;
+ }
Review Comment:
removing the old code path, it's no longer used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
