Sxnan commented on code in PR #24088: URL: https://github.com/apache/flink/pull/24088#discussion_r1454945796
########## flink-core/src/main/java/org/apache/flink/configuration/Configuration.java: ########## Review Comment: That makes sense. However, [FLINK-34082](https://issues.apache.org/jira/browse/FLINK-34082) is for removing the deprecated methods. How about we create another ticket to ensure that we mark them as `Internal` in 2.0? ########## flink-core/src/main/java/org/apache/flink/configuration/Configuration.java: ########## @@ -179,7 +182,9 @@ public String getString(String key, String defaultValue) { * * @param configOption The configuration option * @return the (default) value associated with the given config option + * @deprecated use {@link #get(ConfigOption)} or {@link #getOptional(ConfigOption)} */ + @Deprecated Review Comment: I just found out that we replace directly in #23456. If both ways exist, and we don't have a clear guide to make the choice, I am fine with either way. Feel free to close the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
