JunRuiLee commented on code in PR #24127:
URL: https://github.com/apache/flink/pull/24127#discussion_r1457309568
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -146,6 +144,12 @@ public class ExecutionConfig implements Serializable,
Archiveable<ArchivedExecut
*/
private final Configuration configuration;
+ private final SerializerConfig serializerConfig;
+
+ public SerializerConfig getSerializerConfig() {
+ return serializerConfig;
Review Comment:
Is it appropriate for this object to be part of the public API? I couldn't
find this change mentioned in the FLIP.
If not, I prefer to annotate this method by Internal. If yes, the change
should be reflected in the "Public Propose" section of the FLIP documentation.
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -1097,21 +1008,6 @@ public ArchivedExecutionConfig archive() {
// ------------------------------ Utilities
----------------------------------
- public static class SerializableSerializer<T extends Serializer<?> &
Serializable>
- implements Serializable {
Review Comment:
Given that the SerializableSerializer is part of the public API, we cannot
simply remove it. Additionally, we should avoid directly updating any return
types of Public API that use SerializableSerializer. I suggest to maintain the
current implementation without changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
