[ 
https://issues.apache.org/jira/browse/FLINK-33951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacky Lau updated FLINK-33951:
------------------------------
    Description: 
we check whether exists retract method using needRetraction which is operator 
level. but not all of the agg should use agg with retract.

so we should check agg when there are is needRetraction 

for example the planner has improvement for max/min function using RelMd 
Monotonicity. such as there are have two level agg, first agg produce count and 
second agg max(cnt). we can use MaxAggFunction instead of 
MaxWithRetractAggFunction because MaxWithRetractAggFunction has low performance.

 

  was:
we check whether exists retract method using needRetraction which is operator 
level. but not all of the agg should use agg with retract.

for example the planner has improvement for max/min function using RelMd 
Monotonicity. such as there are have two level agg, first agg produce count and 
second agg max(cnt). we can use MaxAggFunction instead of 
MaxWithRetractAggFunction because MaxWithRetractAggFunction has low performance.

That is the operator level retract method check will cause m


> should use aggCallNeedRetractions instead of needRetraction to check retract 
> method, orelse throw not implement retract method
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-33951
>                 URL: https://issues.apache.org/jira/browse/FLINK-33951
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>    Affects Versions: 1.19.0
>            Reporter: Jacky Lau
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>
> we check whether exists retract method using needRetraction which is operator 
> level. but not all of the agg should use agg with retract.
> so we should check agg when there are is needRetraction 
> for example the planner has improvement for max/min function using RelMd 
> Monotonicity. such as there are have two level agg, first agg produce count 
> and second agg max(cnt). we can use MaxAggFunction instead of 
> MaxWithRetractAggFunction because MaxWithRetractAggFunction has low 
> performance.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to