[ 
https://issues.apache.org/jira/browse/FLINK-33950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808565#comment-17808565
 ] 

Jacky Lau commented on FLINK-33950:
-----------------------------------

[~twalthr] yeap, but BinaryRowData's doesn't have setRowData method, these code 
is draw inspiration from Spark, spark also doesn't support. so it may not be 
easy to do. and there are lots of DeclarativeAggregateFunction we should 
imigrate. we should fix it , will you have plan to support it?
{code:java}
/**
 * If it is a fixed-length field, we can call this BinaryRowData's setXX method 
for in-place
 * updates. If it is variable-length field, can't use this method, because the 
underlying data
 * is stored continuously.
 */
public static boolean isInFixedLengthPart(LogicalType type) { {code}

> Update max aggregate functions to new type system
> -------------------------------------------------
>
>                 Key: FLINK-33950
>                 URL: https://issues.apache.org/jira/browse/FLINK-33950
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner
>    Affects Versions: 1.19.0
>            Reporter: Jacky Lau
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to