1996fanrui commented on code in PR #24003:
URL: https://github.com/apache/flink/pull/24003#discussion_r1461348956
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/FixedDelayRestartBackoffTimeStrategy.java:
##########
@@ -61,8 +61,9 @@ public long getBackoffTime() {
}
@Override
- public void notifyFailure(Throwable cause) {
+ public boolean notifyFailure(Throwable cause) {
currentRestartAttempt++;
+ return true;
Review Comment:
> I guess, you meant
[FLIP-364](https://cwiki.apache.org/confluence/display/FLINK/FLIP-364%3A+Improve+the+exponential-delay+restart-strategy)
here?
Exactly, sorry for my typo.
> What about deprecating that class as part of this PR and coming up with a
follow-up Jira issue that replaces the strategy?
They are internal class, IIUC, we can refactor it directly without the
`@Deprecated` annotation.
---------------------------------------------------------------------------------
Your suggestion is that we still keep the failure-rate and fixed-delay
restart-strategies, but we can reuse the
`ExponentialDelayRestartBackoffTimeStrategy` class, right?
I'm thinking could we deprecate failure-rate and fixed-delay
restart-strategies directly? Users can configure them directly.
Keep failure-rate and fixed-delay restart-strategies and reusing
`ExponentialDelayRestartBackoffTimeStrategy` class still has the semantic
problem that I mentioned in the last comment [1].
[1] https://github.com/apache/flink/pull/24003#discussion_r1456807889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
