LadyForest opened a new pull request, #24172:
URL: https://github.com/apache/flink/pull/24172
## What is the purpose of the change
This PR fixes the unstable test case
`TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate`.
I attempted to reproduce the failure, but I have been unsuccessful in
replicating the issue in the local environment. However, upon inspecting the
table's maven log, I did identify some common attributes shared by the failed
cases. It is worth noting that all the failures occurred when the state backend
type was set to `HEAP`.
I suspect that the issue may have arisen because I performed two checks
within a single test case. This is likely problematic because the HEAP uses a
shared statebackend directory within the test, whereas RocksDB generates a
distinct one each time. Modifying the test should be able to resolve this issue.
```
# heap first run
18:30:10,490 [jobmanager-io-thread-21] INFO
org.apache.flink.runtime.jobmaster.JobMaster [] - Using
job/cluster config to configure application-defined state backend:
MemoryStateBackend (data in heap memory / checkpoints to JobManager)
(checkpoints:
'file:/tmp/org.apache.flink.table.planner.runtime.stream.table.TableAggregateITCase2122011191309948972',
savepoints: 'null, maxStateSize: 5242880)
# heap second run
18:30:10,894 [jobmanager-io-thread-29] INFO
org.apache.flink.runtime.jobmaster.JobMaster [] - Using
job/cluster config to configure application-defined state backend:
MemoryStateBackend (data in heap memory / checkpoints to JobManager)
(checkpoints:
'file:/tmp/org.apache.flink.table.planner.runtime.stream.table.TableAggregateITCase2122011191309948972',
savepoints: 'null, maxStateSize: 5242880)
# rocksdb first run
07:25:56,198 [GroupTableAggregate[130] -> Calc[131] -> SinkConversion[132]
-> Sink: Unnamed (1/1)#0] INFO
org.apache.flink.contrib.streaming.state.RocksDBKeyedStateBackendBuilder [] -
Finished building RocksDB keyed state-backend at
/tmp/junit7454986721637689418/junit5007728163575453684/minicluster_6563313f5ee6acd20722570d8ee3f603/tm_0/tmp/job_4533b42d0c81a9802d737351ccde6227_op_KeyedProcessOperator_fd6cc938aebe8552b8ddacecdb53eb63__1_1__uuid_5ae4637b-a86c-4aec-b9fc-de22680251ca.
# rocksdb second run
07:25:56,734 [GroupTableAggregate[141] -> Calc[142] -> SinkConversion[143]
-> Sink: Unnamed (1/1)#0] INFO
org.apache.flink.contrib.streaming.state.RocksDBKeyedStateBackendBuilder [] -
Finished building RocksDB keyed state-backend at
/tmp/junit7454986721637689418/junit5007728163575453684/minicluster_6563313f5ee6acd20722570d8ee3f603/tm_0/tmp/job_df30e81186a25ba0221aaf4a6e4aa56d_op_KeyedProcessOperator_fd6cc938aebe8552b8ddacecdb53eb63__1_1__uuid_1c2cea2b-ec6a-47de-957e-a1ffe4d1ea66.
```
## Brief change log
Split test cases and fix typo.
## Verifying this change
The CI should pass and no more unstable cases occur.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
