1996fanrui opened a new pull request, #761:
URL: https://github.com/apache/flink-kubernetes-operator/pull/761

   ## What is the purpose of the change
   
   [FLINK-33098](https://issues.apache.org/jira/browse/FLINK-33098) still using 
the jackson version of flink-kubernetes-operator instead of flink shaded 
version. It can be updated after `flink-1.18.1` is released.
   
   The reason is : current autoscaler is using the loaderOptions to limit the 
serialized size.
   
   - The shaded jackson version of `flink-1.17` is 2.13.4-16.1, it doesn't 
support the loaderOptions.
   - The shaded jackson version of `flink-1.18` is 2.14.2-17.0, it supports the 
loaderOptions.
   
   For details can be get from this comment[1].
   
   ## Brief change log
   
   - [FLINK-33287] Using the flink shaded jackson for flink-autoscaler
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): removed some 
dependencies from autoscaler related modules
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: 
no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  no
   
   
   [1] 
https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1336571925
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to