mbalassi commented on code in PR #24065:
URL: https://github.com/apache/flink/pull/24065#discussion_r1464456656
##########
docs/content.zh/docs/deployment/resource-providers/native_kubernetes.md:
##########
@@ -97,14 +97,34 @@ COPY /path/of/my-flink-job.jar
$FLINK_HOME/usrlib/my-flink-job.jar
After creating and publishing the Docker image under `custom-image-name`, you
can start an Application cluster with the following command:
```bash
+# Local Schema
$ ./bin/flink run-application \
--target kubernetes-application \
-Dkubernetes.cluster-id=my-first-application-cluster \
-Dkubernetes.container.image.ref=custom-image-name \
local:///opt/flink/usrlib/my-flink-job.jar
+
+# FileSystem
+$ ./bin/flink run-application \
+ --target kubernetes-application \
+ -Dkubernetes.cluster-id=my-first-application-cluster \
+ -Dkubernetes.container.image=custom-image-name \
+ s3://my-bucket/my-flink-job.jar
+
+# HTTP(S)
+$ ./bin/flink run-application \
+ --target kubernetes-application \
+ -Dkubernetes.cluster-id=my-first-application-cluster \
+ -Dkubernetes.container.image=custom-image-name \
+ http://ip:port/my-flink-job.jar
```
+{{< hint info >}}
+Now, The jar artifact supports downloading from the [flink filesystem]({{< ref
"docs/deployment/filesystems/overview" >}}) or Http/Https in Application Mode.
Review Comment:
nit: remove `Now,`
##########
docs/content.zh/docs/deployment/resource-providers/native_kubernetes.md:
##########
@@ -326,7 +346,7 @@ $ kubectl create clusterrolebinding
flink-role-binding-default --clusterrole=edi
```
If you do not want to use the `default` service account, use the following
command to create a new `flink-service-account` service account and set the
role binding.
-Then use the config option
`-Dkubernetes.service-account=flink-service-account` to make the JobManager pod
use the `flink-service-account` service account to create/delete TaskManager
pods and leader ConfigMaps.
+Then use the config option
`-Dkubernetes.service-account=flink-service-account` to configure the
JobManager pods service account used to create and delete TaskManager pods and
leader ConfigMaps.
Review Comment:
nit: `JobManager pod's`
##########
docs/layouts/shortcodes/generated/artifact_fetch_configuration.html:
##########
@@ -0,0 +1,36 @@
+<table class="configuration table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 20%">Key</th>
+ <th class="text-left" style="width: 15%">Default</th>
+ <th class="text-left" style="width: 10%">Type</th>
+ <th class="text-left" style="width: 55%">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><h5>user.artifacts.artifact-list</h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>List<String></td>
+ <td>A semicolon-separated list of the additional artifacts to
fetch for the job before setting up the application cluster. All given elements
have to be valid URIs. Example:
s3://sandbox-bucket/format.jar;http://sandbox-server:1234/udf.jar</td>
Review Comment:
Why are we switching to semicolon seperator from commas as used by `--jars`?
##########
docs/content.zh/docs/deployment/resource-providers/native_kubernetes.md:
##########
@@ -97,14 +97,34 @@ COPY /path/of/my-flink-job.jar
$FLINK_HOME/usrlib/my-flink-job.jar
After creating and publishing the Docker image under `custom-image-name`, you
can start an Application cluster with the following command:
```bash
+# Local Schema
$ ./bin/flink run-application \
--target kubernetes-application \
-Dkubernetes.cluster-id=my-first-application-cluster \
-Dkubernetes.container.image.ref=custom-image-name \
local:///opt/flink/usrlib/my-flink-job.jar
+
+# FileSystem
+$ ./bin/flink run-application \
+ --target kubernetes-application \
+ -Dkubernetes.cluster-id=my-first-application-cluster \
+ -Dkubernetes.container.image=custom-image-name \
+ s3://my-bucket/my-flink-job.jar
+
+# HTTP(S)
+$ ./bin/flink run-application \
+ --target kubernetes-application \
+ -Dkubernetes.cluster-id=my-first-application-cluster \
+ -Dkubernetes.container.image=custom-image-name \
+ http://ip:port/my-flink-job.jar
```
+{{< hint info >}}
+Now, The jar artifact supports downloading from the [flink filesystem]({{< ref
"docs/deployment/filesystems/overview" >}}) or Http/Https in Application Mode.
+The jar package will be downloaded from filesystem to
+[user.artifacts.base.dir]({{< ref "docs/deployment/config"
>}}#user-artifacts-base-dir)/[kubernetes.namespace]({{< ref
"docs/deployment/config" >}}#kubernetes-namespace)/[kubernetes.cluster-id]({{<
ref "docs/deployment/config" >}}#kubernetes-cluster-id) path in image.
+{{< /hint >}}
-<span class="label label-info">Note</span> `local` is the only supported
scheme in Application Mode.
+<span class="label label-info">Note</span> `local` schema is still supported.
If you use `local` schema, the jar must be provided in the image or download by
a init container as described in this [example](#example-of-pod-template).
Review Comment:
nit: `downloaded by`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
