X-czh commented on code in PR #24182:
URL: https://github.com/apache/flink/pull/24182#discussion_r1464658457
##########
flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfig.java:
##########
@@ -352,6 +361,20 @@ public void configure(ReadableConfig configuration,
ClassLoader classLoader) {
.getOptional(PipelineOptions.KRYO_REGISTERED_CLASSES)
.map(c -> loadClasses(c, classLoader, "Could not load kryo
type to be registered."))
.ifPresent(c -> this.registeredKryoTypes = c);
+
+ try {
+ configuration
+ .getOptional(PipelineOptions.SERIALIZATION_CONFIG)
+ .ifPresent(c ->
parseSerializationConfigWithExceptionHandling(classLoader, c));
+ } catch (Exception e) {
+ if (!GlobalConfiguration.isStandardYaml()) {
+ throw new UnsupportedOperationException(
+ String.format(
+ "%s is only supported with the standard YAML
config parser, please use \"config.yaml\" as the config file.",
+ PipelineOptions.SERIALIZATION_CONFIG.key()));
+ }
Review Comment:
Seems unnecessary, we are certain that it won't work when using the legacy
parser. So, this is already a concise root cause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
