jiangxin369 commented on code in PR #23851:
URL: https://github.com/apache/flink/pull/23851#discussion_r1464734165
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/CreditBasedInputBuffersUsageGauge.java:
##########
@@ -28,27 +31,35 @@
*/
public class CreditBasedInputBuffersUsageGauge extends
AbstractBuffersUsageGauge {
- private final FloatingBuffersUsageGauge floatingBuffersUsageGauge;
- private final ExclusiveBuffersUsageGauge exclusiveBuffersUsageGauge;
-
- public CreditBasedInputBuffersUsageGauge(
- FloatingBuffersUsageGauge floatingBuffersUsageGauge,
- ExclusiveBuffersUsageGauge exclusiveBuffersUsageGauge,
- SingleInputGate[] inputGates) {
+ public CreditBasedInputBuffersUsageGauge(SingleInputGate[] inputGates) {
Review Comment:
These metrics are registered in `NettyShuffleMetricFactory` and would be
exposed to users, to keep consistency with the current behavior, I think we
should keep these metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
