xishuaidelin commented on code in PR #24159: URL: https://github.com/apache/flink/pull/24159#discussion_r1464767224
########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/bundle/InputSideHasNoUniqueKeyBundle.java: ########## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.operators.join.stream.bundle; + +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.data.util.RowDataUtil; +import org.apache.flink.types.RowKind; + +import javax.annotation.Nullable; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.ListIterator; +import java.util.Map; + +/** For the case that input has no uniqueKey. */ +public class InputSideHasNoUniqueKeyBundle implements BufferBundle { + + /** + * The structure of the bundle: first-level key is the joinKey while the second-level key is the + * hash value of the record. And the value of the second hash is a list of records. The bundle + * only stores the accumulated records.When the retract record occurs it would find the + * corresponding records(accumulated) and remove it. + */ + private final Map<RowData, Map<Integer, List<RowData>>> bundle; + + private int count; + + private int actualSize; + + public InputSideHasNoUniqueKeyBundle() { + this.bundle = new HashMap<>(); + this.count = 0; + this.actualSize = 0; + } + + @Override + public boolean isEmpty() { Review Comment: @lsyldliu yes，I hava extracted them. clear method includes bundle, so it is left in the subclass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
