reswqa commented on code in PR #24193:
URL: https://github.com/apache/flink/pull/24193#discussion_r1466089942
##########
flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfig.java:
##########
@@ -185,16 +205,25 @@ public void registerPojoType(Class<?> type) {
* serialized with Kryo, then it will be registered at Kryo to make sure
that only tags are
* written.
*
+ * <p>The method will be converted to private in the next Flink major
version after removing its
+ * deprecated caller methods.
+ *
* @param type The class of the type to register.
*/
+ @Internal
public void registerKryoType(Class<?> type) {
if (type == null) {
throw new NullPointerException("Cannot register null type class.");
}
registeredKryoTypes.add(type);
}
- /** Returns the registered types with Kryo Serializers. */
+ /**
+ * Returns the registered types with Kryo Serializers.
+ *
+ * @deprecated The method is deprecated because {@link
ExecutionConfig.SerializableSerializer}
Review Comment:
If we want to deprecate a method, It must has an alternative implementations.
##########
flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfig.java:
##########
@@ -185,16 +205,25 @@ public void registerPojoType(Class<?> type) {
* serialized with Kryo, then it will be registered at Kryo to make sure
that only tags are
* written.
*
+ * <p>The method will be converted to private in the next Flink major
version after removing its
+ * deprecated caller methods.
+ *
* @param type The class of the type to register.
*/
+ @Internal
public void registerKryoType(Class<?> type) {
if (type == null) {
throw new NullPointerException("Cannot register null type class.");
}
registeredKryoTypes.add(type);
}
- /** Returns the registered types with Kryo Serializers. */
+ /**
+ * Returns the registered types with Kryo Serializers.
+ *
+ * @deprecated The method is deprecated because {@link
ExecutionConfig.SerializableSerializer}
+ * is deprecated.
+ */
public LinkedHashMap<Class<?>, ExecutionConfig.SerializableSerializer<?>>
Review Comment:
It doesn't has `@Deprecated` annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
