xishuaidelin commented on code in PR #24161:
URL: https://github.com/apache/flink/pull/24161#discussion_r1466230805
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/JoinUtil.scala:
##########
@@ -95,6 +105,18 @@ object JoinUtil {
}
}
+ /** Creates a MiniBatch trigger for join depends on the config. */
+ def createMiniBatchTrigger(config: ReadableConfig):
CountCoBundleTrigger[RowData, RowData] = {
Review Comment:
Yes, This would make the code more clear. I would finish it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
