snuyanzin commented on code in PR #136:
URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1466384524
##########
pom.xml:
##########
@@ -65,6 +65,7 @@ under the License.
<netty.version>4.1.100.Final</netty.version>
<jackson.version>2.15.3</jackson.version>
<guava.version>32.1.3-jre</guava.version>
+ <flink.markBundledAsOptional>true</flink.markBundledAsOptional>
Review Comment:
If I understand things around
[MNG-5899](https://issues.apache.org/jira/browse/MNG-5899) correctly in maven
they stopped reuse dependency reduced pom produced by shade plugin however they
didn't forbid manipulation on api level.
At the same time on api level it is still possible to get some info e.g.
list of dependencies from maven and then make some manipulation in code with
this list of dependencies, this is how it was in maven-shade-plugin [1]. After
[MSHADE-413](https://issues.apache.org/jira/browse/MSHADE-413) instead of
manipulation on collection of objects received from maven they started to clone
it first and then perform same manipulation on cloned version
[1]
https://github.com/apache/maven-shade-plugin/pull/124/files#diff-083ef87367e79a2ea6b333846149588f4ce284ed930db1d87712fdbf9111e381L1066-L1112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
