reswqa commented on code in PR #24187:
URL: https://github.com/apache/flink/pull/24187#discussion_r1466393637
##########
flink-core/src/main/java/org/apache/flink/api/common/state/StateDescriptor.java:
##########
@@ -320,7 +320,10 @@ public void initializeSerializerUnlessSet(ExecutionConfig
executionConfig) {
@Override
public <T> TypeSerializer<T> createSerializer(
TypeInformation<T> typeInformation) {
- return
typeInformation.createSerializer(executionConfig);
+ return typeInformation.createSerializer(
Review Comment:
To be honest, this is a bit of a subtlety. In the early days of flink, there
was a lack of consideration of whether a variable could be null. I have
checked that most of the caller of `TypeInformation#createSerialize` and they
were fine. Unfortunately, there are some exceptions, such as here. 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
