leonardBang commented on code in PR #21:
URL:
https://github.com/apache/flink-connector-mongodb/pull/21#discussion_r1466631405
##########
.github/workflows/push_pr.yml:
##########
@@ -25,7 +25,14 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT, 1.19-SNAPSHOT]
+ flink: [ 1.16-SNAPSHOT, 1.17-SNAPSHOT ]
+ jdk: [ '8, 11' ]
+ include:
+ - flink: 1.18-SNAPSHOT
+ jdk: '8, 11, 17'
+ - flink: 1.19-SNAPSHOT
+ jdk: '8, 11, 17, 21'
Review Comment:
I'm not sure current matrix is you want or not, maybe you need something
like if I understand azure pipeline yaml correctly?
```
flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT, 1.19-SNAPSHOT]
jdk: ['8, 11, 17, 21']
exclude:
- flink: 1.16-SNAPSHOT
jdk: '17, 21'
- flink: 1.17-SNAPSHOT
jdk: '21'
```
##########
.github/workflows/weekly.yml:
##########
@@ -34,25 +34,26 @@ jobs:
branch: main
}, {
flink: 1.18-SNAPSHOT,
+ jdk: '8, 11, 17',
branch: main
}, {
flink: 1.19-SNAPSHOT,
+ jdk: '8, 11, 17, 21',
branch: main
}, {
flink: 1.16.2,
- branch: v1.0
+ branch: v3.1
}, {
flink: 1.17.1,
- branch: v1.0
- },{
- flink: 1.18.0,
- branch: v1.0
+ branch: v3.1
}, {
- flink: 1.19-SNAPSHOT,
- branch: v1.0
+ flink: 1.18.0,
Review Comment:
Could we bump the flink version to latest minor version?
##########
flink-connector-mongodb/pom.xml:
##########
@@ -32,6 +32,13 @@ under the License.
<packaging>jar</packaging>
+ <properties>
+ <surefire.module.config>
+ --add-opens=java.base/java.util=ALL-UNNAMED
+ --add-opens=java.base/java.lang=ALL-UNNAMED
+ </surefire.module.config>
Review Comment:
Could you explain a little why we need this ?
##########
.github/workflows/weekly.yml:
##########
@@ -34,25 +34,26 @@ jobs:
branch: main
}, {
flink: 1.18-SNAPSHOT,
+ jdk: '8, 11, 17',
branch: main
}, {
flink: 1.19-SNAPSHOT,
+ jdk: '8, 11, 17, 21',
branch: main
}, {
flink: 1.16.2,
- branch: v1.0
+ branch: v3.1
Review Comment:
Do we have a branch named `v3.1` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
