[ https://issues.apache.org/jira/browse/FLINK-34237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811082#comment-17811082 ]
Xintong Song commented on FLINK-34237: -------------------------------------- Thanks for reporting. This is indeed an unintended breaking change and a blocker for Flink 1.19. We thought `SourceReaderContext` is only called by various connectors and were not aware of that it is also implemented by connectors. FLIP-382 is for clean-up purposes and does not introduce any new feature. Even in Flink 2.0, I think we should not require all connectors to change their codes only for such clean-up purposes. So let's simply revert changes for this interface. [~Wencong Liu], could you please help fix this? > MongoDB connector compile failed with Flink 1.19-SNAPSHOT > --------------------------------------------------------- > > Key: FLINK-34237 > URL: https://issues.apache.org/jira/browse/FLINK-34237 > Project: Flink > Issue Type: Bug > Components: API / Core, Connectors / MongoDB > Reporter: Leonard Xu > Priority: Blocker > Fix For: mongodb-1.1.0 > > > {code:java} > Error: Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile > (default-compile) on project flink-connector-mongodb: Compilation failure > 134Error: > /home/runner/work/flink-connector-mongodb/flink-connector-mongodb/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/MongoSourceReaderContext.java:[35,8] > org.apache.flink.connector.mongodb.source.reader.MongoSourceReaderContext is > not abstract and does not override abstract method getTaskInfo() in > org.apache.flink.api.connector.source.SourceReaderContext > 135{code} > [https://github.com/apache/flink-connector-mongodb/actions/runs/7657281844/job/20867604084] > This is related to FLINK-33905 > One point: As > [FLIP-382|https://cwiki.apache.org/confluence/display/FLINK/FLIP-382%3A+Unify+the+Provision+of+Diverse+Metadata+for+Context-like+APIs] > is accepted, all connectors who implement SourceReaderContext (i.e > MongoSourceReaderContext) should implement new introduced methods ` > getTaskInfo()` if they want to compile/work with Flink 1.19. As I just have a > rough look at the FLIP, maybe [~xtsong] and [~Wencong Liu] could comment > under this issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)