Tan-JiaLiang commented on PR #60: URL: https://github.com/apache/flink-connector-kafka/pull/60#issuecomment-1911588128
@MartijnVisser Sorry late. > Do we have tests for them? To be honest, I checked all connectors(e.g. jdbc/hbase/filesystem...) but there is no test case for forward options. Forward options is a set of ConfigOption that are directly forwarded to the runtime implementation but don't affect the final execution topology. And according to the design of FLINK-24456, `scan.bounded.mode`, `scan.bounded.specific-offsets`, `scan.bounded.timestamp-millis` should be forward options. > And can you also check the Chinese docs? Yes, I filled in the gaps in the Chinese documentation and translated the content. Finally, the `sink.parallelism` option should not be a forward option, as it can lead to inconsistent parallelism between upstream and downstream operators and change the execution topology. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
