[
https://issues.apache.org/jira/browse/FLINK-34052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811556#comment-17811556
]
Zhanghao Chen edited comment on FLINK-34052 at 1/27/24 4:25 PM:
----------------------------------------------------------------
After invertigation, it turned out that the issue was resulted as follows:
* The maven shade plugin will by default shade replaces with original jar with
the result of shading. So, when a {{pom.xml}} includes two shades, the second
shade execution will (by default) start from the result of the first shade
execution ([ref|https://maven.apache.org/plugins/maven-shade-plugin/faq.html]).
* We set the [#finalName] param to prevent the file replacement behavior as
we'd like to build multiple independent example jars.
* However, maven by default will only install the default project artifact
into the repo, omitting those shaded artifacts with finalName specified. This
leads to the problem as reported in this issue.
To fix it, we can set the
[shadedArtifactAttached|https://maven.apache.org/plugins/maven-shade-plugin/examples/attached-artifact.html]
param, which tells maven to install the shaded artifact aside from the default
project artifact. I've attached a fix PR on it.
was (Author: zhanghao chen):
After invertigation, it turned out that the issue was resulted as follows:
* The maven shade plugin will by default shade replaces with original jar with
the result of shading. So, when a {{pom.xml}} includes two shades, the second
shade execution will (by default) start from the result of the first shade
execution ([ref|https://maven.apache.org/plugins/maven-shade-plugin/faq.html]).
* We set the
[finalName|[https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#finalName|https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#finalName]).]]
param to prevent the file replacement behavior as we'd like to build multiple
independent example jars.
* However, maven by default will only install the default project artifact
into the repo, omitting those shaded artifacts with finalName specified. This
leads to the problem as reported in this issue.
To fix it, we can set the
[shadedArtifactAttached|https://maven.apache.org/plugins/maven-shade-plugin/examples/attached-artifact.html]
param, which tells maven to install the shaded artifact aside from the default
project artifact. I've attached a fix PR on it.
> Missing TopSpeedWindowing and SessionWindowing JARs in Flink Maven Repository
> -----------------------------------------------------------------------------
>
> Key: FLINK-34052
> URL: https://issues.apache.org/jira/browse/FLINK-34052
> Project: Flink
> Issue Type: Bug
> Components: Build System, Examples
> Affects Versions: 1.18.0
> Reporter: Junrui Li
> Assignee: Zhanghao Chen
> Priority: Major
>
> As a result of the changes implemented in FLINK-32821, the build process no
> longer produces artifacts with the names
> flink-examples-streaming-1.x-TopSpeedWindowing.jar and
> flink-examples-streaming-1.x-SessionWindowing.jar. This has led to the
> absence of these specific JAR files in the Maven repository
> (https://repo1.maven.org/maven2/org/apache/flink/flink-examples-streaming/1.18.0/).
> These artifacts were previously available and may still be expected by users
> as part of their application dependencies. Their removal could potentially
> break existing build pipelines and applications that depend on these example
> JARs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
