XComp commented on code in PR #24132:
URL: https://github.com/apache/flink/pull/24132#discussion_r1469397883
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java:
##########
@@ -86,12 +117,38 @@ public KubernetesLeaderElector(
newLeader,
leaderConfig.getConfigMapName())))
.build();
+ this.executorService = executorService;
+
+ LOG.info(
+ "Create KubernetesLeaderElector on lock {}.",
+ leaderElectionConfig.getLock().describe());
+ }
+
+ @GuardedBy("lock")
+ private void resetInternalLeaderElector() {
+ stopLeaderElectionCycle();
+
internalLeaderElector =
new LeaderElector(kubernetesClient, leaderElectionConfig,
executorService);
+ currentLeaderElectionSession = internalLeaderElector.start();
+
LOG.info(
- "Create KubernetesLeaderElector {} with lock identity {}.",
- leaderConfig.getConfigMapName(),
- leaderConfig.getLockIdentity());
+ "Triggered leader election on lock {}.",
leaderElectionConfig.getLock().describe());
+ }
+
+ @GuardedBy("lock")
+ private void stopLeaderElectionCycle() {
+ if (internalLeaderElector != null) {
+ Preconditions.checkNotNull(currentLeaderElectionSession);
+
+ // the current leader election cycle needs to be cancelled before
releasing the lock to
+ // avoid retrying
+ currentLeaderElectionSession.cancel(true);
+ currentLeaderElectionSession = null;
+
+ internalLeaderElector.release();
Review Comment:
Reconsidering what I said before - upgrading even for 1.18 might be
necessary. We don't want to keep another (known) bug lingering around in Flink
1.18.
I upgraded the dependency to 6.9.0 and will do a pass through the diff
between v6.6.2 and v6.9.0 to check whether there's something else we have to
keep in mind. :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
