Github user fpompermaier commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2790#discussion_r88567247
  
    --- Diff: 
flink-streaming-connectors/flink-connector-elasticsearch2/src/test/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSinkITCase.java
 ---
    @@ -210,6 +216,122 @@ public void cancel() {
                        running = false;
                }
        }
    +   
    +   @Test
    +   public void testTemplateCreation() throws Exception {
    +           // Settings.Builder 
settings=Settings.settingsBuilder().put("","");
    +
    +           Map<String, String> config = new HashMap<>();
    +           // This instructs the sink to emit after every element, 
otherwise they
    +           // would be buffered
    +           config.put(ElasticsearchSink.CONFIG_KEY_BULK_FLUSH_MAX_ACTIONS, 
"1");
    +           config.put("cluster.name", "my-transport-client-cluster");
    --- End diff --
    
    Try to see if "cluster.name" can be replaced by 
ClusterName.CLUSTER_NAME_SETTING


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to