leonardBang commented on code in PR #707:
URL: https://github.com/apache/flink-web/pull/707#discussion_r1471076802
##########
docs/data/release_archive.yml:
##########
@@ -545,6 +545,11 @@ release_archive:
version: 4.1.0
release_date: 2023-12-28
filename: "pulsar"
+ - name: "Flink JDBC Connector"
+ connector: "jdbc"
+ version: 3.1.2
+ release_date: 2024-05-01
Review Comment:
+1
##########
docs/data/flink_connectors.yml:
##########
@@ -44,11 +44,11 @@ gcp-pubsub:
compatibility: ["1.16.x", "1.17.x"]
jdbc:
- name: "Apache Flink JDBC Connector 3.1.1"
- source_release_url:
"https://www.apache.org/dyn/closer.lua/flink/flink-connector-jdbc-3.1.1/flink-connector-jdbc-3.1.1-src.tgz";
- source_release_asc_url:
"https://downloads.apache.org/flink/flink-connector-jdbc-3.1.1/flink-connector-jdbc-3.1.1-src.tgz.asc";
- source_release_sha512_url:
"https://downloads.apache.org/flink/flink-connector-jdbc-3.1.1/flink-connector-jdbc-3.1.1-src.tgz.sha512";
- compatibility: ["1.16.x", "1.17.x"]
+ name: "Apache Flink JDBC Connector 3.1.2"
+ source_release_url:
"https://www.apache.org/dyn/closer.lua/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz";
+ source_release_asc_url:
"https://downloads.apache.org/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz.asc";
+ source_release_sha512_url:
"https://downloads.apache.org/flink/flink-connector-jdbc-3.1.2/flink-connector-jdbc-3.1.2-src.tgz.sha512";
+ compatibility: ["1.16.x", "1.17.x", "1.18.x"]
Review Comment:
> The flink.version that's set in the root pom.xml should be set to the
lowest Flink version that's supported. You can't use highest because there are
no guarantees that something that's working in e.g. Flink 1.18 is working in
Flink 1.17.
https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development
said above, but here we're actually
https://github.com/apache/flink-connector-jdbc/blob/v3.1.2-rc2/pom.xml#L50 ,
how we ensure we can support Flink 1.16.x?
As the flink version 1.17 has been used in `Apache Flink JDBC Connector
3.1.1`, I agree this is a history issue and not sure it's a blocker or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
