zentol commented on code in PR #24231:
URL: https://github.com/apache/flink/pull/24231#discussion_r1471295861
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderElectionDriver.java:
##########
@@ -89,11 +85,6 @@ public KubernetesLeaderElectionDriver(
kubeClient.createLeaderElector(
leaderElectionConfiguration, new
LeaderCallbackHandlerImpl());
- this.configMapLabels =
- KubernetesUtils.getConfigMapLabels(
Review Comment:
Only some labels are deprecated, not all of them (like app/type).
These 2 in particular aren't very useful because they are static values. I
don't see a big use-case for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
