JingGe commented on code in PR #24140:
URL: https://github.com/apache/flink/pull/24140#discussion_r1468844018


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkBatchRuleSets.scala:
##########
@@ -268,7 +268,7 @@ object FlinkBatchRuleSets {
 
     // reduce aggregate functions like AVG, STDDEV_POP etc.
     CoreRules.AGGREGATE_REDUCE_FUNCTIONS,
-    WindowAggregateReduceFunctionsRule.INSTANCE,
+    
WindowAggregateReduceFunctionsRule.WINDOW_AGGREGATE_REDUCE_FUNCTIONS_INSTANCE,

Review Comment:
   Would you like to share your thoughts about using the new static instance 
name? The new name contains redundant information that was already offered by 
the class name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to