twalthr commented on code in PR #24155:
URL: https://github.com/apache/flink/pull/24155#discussion_r1471420707
##########
flink-table/flink-sql-parser/src/main/codegen/data/Parser.tdd:
##########
@@ -147,11 +149,14 @@
"COMPILE"
"COLUMNS"
"DATABASES"
+ "DISTRIBUTED"
+ "DISTRIBUTION"
"DRAIN"
"ENFORCED"
"ESTIMATED_COST"
"EXTENDED"
"FUNCTIONS"
+ "HASH"
Review Comment:
Do you know the difference between `nonReservedKeywords`,
`reservedKeywords`, and `keywords`? I'm wondering if it at least makes sense to
still allow `hash` as a column name without backticks if we add it to the right
list. We currently have too many keywords which basically forces the user to
use backticks all the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
