libenchao commented on code in PR #24234: URL: https://github.com/apache/flink/pull/24234#discussion_r1472697963
########## docs/content/docs/dev/table/sourcesSinks.md: ########## @@ -197,10 +197,16 @@ A table source can implement further ability interfaces such as `SupportsProject mutate an instance during planning. All abilities can be found in the `org.apache.flink.table.connector.source.abilities` package and are listed in the [source abilities table](#source-abilities). -The runtime implementation of a `ScanTableSource` must produce internal data structures. Thus, records -must be emitted as `org.apache.flink.table.data.RowData`. The framework provides runtime converters such +The returned _scan runtime provider_ provides the runtime implementation for reading the data. There are +different interfaces for runtime implementation, among which `SourceProvider` is the recommended core interface. + +Independent of the provider interface, the source runtime implementation must produce internal data structures. +Thus, records must be emitted as `org.apache.flink.table.data.RowData`. The framework provides runtime converters such that a source can still work on common data structures and perform a conversion at the end. +To support parallelism setting, the dynamic table factory should support the optional `scan.parallelism` option Review Comment: Is it worth to mention that `scan.parallelism` has been defined in `FactoryUtil`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
