pvary commented on code in PR #26: URL: https://github.com/apache/flink-connector-cassandra/pull/26#discussion_r1472793569
########## flink-python/setup.py: ########## @@ -0,0 +1,154 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ +from __future__ import print_function + +import io +import os +import sys + +from setuptools import setup +from shutil import rmtree +from xml.etree import ElementTree as ET + +PACKAGE_NAME = 'apache-flink-connector-aws' +# Source files, directories +CURRENT_DIR = os.path.abspath(os.path.dirname(__file__)) +POM_FILE = os.path.join(CURRENT_DIR, '../pom.xml') +README_FILE = os.path.join(CURRENT_DIR, 'README.txt') + +# Generated files and directories +VERSION_FILE = os.path.join( + CURRENT_DIR, + 'pyflink/datastream/connectors/cassandra_connector_version.py') +DEPENDENCY_FILE = os.path.join(CURRENT_DIR, 'dev/dev-requirements.txt') Review Comment: My feeling is that the connector python release **should** contain the java classes need for it to work. So the user just installs flink-python, then the connector package and then everything should work. Pushing additional requirements for the user by finding the relevant jar files and installing them manually sounds like a bad move. Discussed this with @gaborgsomogyi, and we found that it is generally a better solution to just include the relevant jar files to the connector package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
