gyfora opened a new pull request, #770:
URL: https://github.com/apache/flink-kubernetes-operator/pull/770
## What is the purpose of the change
The PodTemplate fields in the CRD currently incorrectly use the Pod time,
when they should be PodTemplateSpec type. This leads to unnecessary
(meaningless) fields and a very large CRD for no gain.
Also accidentally changing fields like apiKind would trigger an unnecessary
upgrade of the job.
This PR is the first step of correcting this mistake. Unfortunately we
cannot simply change the type form Pod to PodTemplateSpec as it's a backward
incompatible change for the users.
While Kubernetes itself would drop the now unsupported fields from the
stored CRs themselves, users would not be able to submit the same CR again as
they would get a validation error from the API server. We should defer the CRD
schema change to the next version.
## Brief change log
- *Change Pod -> PodTemplateSpec but keep the schema in CRD*
- *Improve SpecDiff logic to avoid accidental upgrade due to the dropped
fields*
## Verifying this change
New unit tests + manual verification in local environment.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: yes
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
