X-czh commented on code in PR #24230: URL: https://github.com/apache/flink/pull/24230#discussion_r1475713915
########## docs/content/docs/dev/datastream/fault-tolerance/serialization/types_serialization.md: ########## @@ -359,12 +385,13 @@ You can still use the same method as in Java as a fallback. There are two ways to create a TypeSerializer. The first is to simply call `typeInfo.createSerializer(config)` on the `TypeInformation` object. -The `config` parameter is of type `ExecutionConfig` and holds the information about the program's registered -custom serializers. Where ever possibly, try to pass the programs proper ExecutionConfig. You can usually -obtain it from `DataStream` via calling `getExecutionConfig()`. +The `config` parameter is of type `SerializerConfig` and holds the information about the program's registered Review Comment: I had offline discussion with @reswqa. Users may need to create `TypeSerializer` directly under two cases: 1. When defining a custom `TypeInrfomation`, they may need to get `TypeSerializer` of some other types to return the `TypeSerializer` of their custom type in the `TypeInformation#createSerializer` method. Here, they can directly get the proper `SerializerConfig` object from the method argument. 2. A user may directly create `TypeSerializer` in the impl of their custom functions. This is discouraged and they should use `getRuntimeContext().createSerializer` instead. Therefore, we'll remove the relevent description on how to get the proper `SerializerConfig` from `ExecutionConfig`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
