lsyldliu commented on code in PR #24228:
URL: https://github.com/apache/flink/pull/24228#discussion_r1477192926
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/sort/SortCodeGenerator.scala:
##########
@@ -41,12 +41,22 @@ import scala.collection.mutable
* input type.
* @param sortSpec
* sort specification.
+ * @param parentCtx
+ * parent CodeGeneratorContext to avoid name conflicts. If the generated
[[NormalizedKeyComputer]]
+ * and [[RecordComparator]] will be used as inner classes, a non-null value
must be set.
*/
class SortCodeGenerator(
tableConfig: ReadableConfig,
classLoader: ClassLoader,
val input: RowType,
- val sortSpec: SortSpec) {
+ val sortSpec: SortSpec,
+ parentCtx: CodeGeneratorContext) {
+
+ def this(
+ tableConfig: ReadableConfig,
+ classLoader: ClassLoader,
+ input: RowType,
+ sortSpec: SortSpec) = this(tableConfig, classLoader, input, sortSpec,
null)
Review Comment:
Please format it.
```
def this(
tableConfig: ReadableConfig,
classLoader: ClassLoader,
input: RowType,
sortSpec: SortSpec) =
this(tableConfig, classLoader, input, sortSpec, null)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
