[
https://issues.apache.org/jira/browse/FLINK-34148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814105#comment-17814105
]
Zakelly Lan commented on FLINK-34148:
-------------------------------------
[~snuyanzin] I triggered a test on commit
[0779c91e|https://github.com/apache/flink/commit/0779c91e581dc16c4aef61d6cc27774f11495907],
it seems the regression is gone:
*01:08:52* Benchmark (lengthStr) (type)
Mode Cnt Score Error Units*01:08:52*
StringSerializationBenchmark.stringWrite 4 ascii thrpt 30
13289.044 ± 55.119 ops/ms*01:08:52* StringSerializationBenchmark.stringWrite
4 russian thrpt 30 11056.146 ± 37.383 ops/ms*01:08:52*
StringSerializationBenchmark.stringWrite 4 chinese thrpt 30
9580.176 ± 41.299 ops/ms*01:08:52* StringSerializationBenchmark.stringWrite
128 ascii thrpt 30 1090.814 ± 1.763 ops/ms*01:08:52*
StringSerializationBenchmark.stringWrite 128 russian thrpt 30
656.249 ± 2.392 ops/ms*01:08:52* StringSerializationBenchmark.stringWrite
128 chinese thrpt 30 504.180 ± 1.091 ops/ms*01:08:52*
StringSerializationBenchmark.stringWrite 16384 ascii thrpt 30
6.041 ± 0.029 ops/ms*01:08:52* StringSerializationBenchmark.stringWrite
16384 russian thrpt 30 3.197 ± 0.010 ops/ms*01:08:52*
StringSerializationBenchmark.stringWrite 16384 chinese thrpt 30
2.272 ± 0.003 ops/ms
Thanks for the fix!
I'm closing this.
> Potential regression (Jan. 13): stringWrite with Java8
> ------------------------------------------------------
>
> Key: FLINK-34148
> URL: https://issues.apache.org/jira/browse/FLINK-34148
> Project: Flink
> Issue Type: Improvement
> Components: API / Type Serialization System
> Reporter: Zakelly Lan
> Assignee: Sergey Nuyanzin
> Priority: Blocker
> Fix For: 1.19.0
>
>
> Significant drop of performance in stringWrite with Java8 from commit
> [881062f352|https://github.com/apache/flink/commit/881062f352f8bf8c21ab7cbea95e111fd82fdf20]
> to
> [5d9d8748b6|https://github.com/apache/flink/commit/5d9d8748b64ff1a75964a5cd2857ab5061312b51]
> . It only involves strings not so long (128 or 4).
> stringWrite.128.ascii(Java8) baseline=1089.107756 current_value=754.52452
> stringWrite.128.chinese(Java8) baseline=504.244575 current_value=295.358989
> stringWrite.128.russian(Java8) baseline=655.582639 current_value=421.030188
> stringWrite.4.chinese(Java8) baseline=9598.791964 current_value=6627.929927
> stringWrite.4.russian(Java8) baseline=11070.666415 current_value=8289.95767
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
