Zakelly commented on code in PR #24181:
URL: https://github.com/apache/flink/pull/24181#discussion_r1477353920
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/WithinCheckpointFileMergingSnapshotManager.java:
##########
@@ -50,6 +50,43 @@ public WithinCheckpointFileMergingSnapshotManager(String id,
Executor ioExecutor
writablePhysicalFilePool = new HashMap<>();
}
+ // ------------------------------------------------------------------------
+ // CheckpointListener
+ // ------------------------------------------------------------------------
+
+ @Override
+ public void notifyCheckpointComplete(SubtaskKey subtaskKey, long
checkpointId)
Review Comment:
When a checkpoint is subsumed, it must be notified completed once before. So
the ```removeAndCloseFiles``` has been called for this checkpoint when it is
subsumed, thus no need another call for it.
And for notification loss scenarios, we will implement
```discardCheckpoint``` to leverage the watermark mechanism to do something
like ```removeAndCloseFiles``` for each SubtaskKey to close the files in
FLINK-32076.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
