Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2829#discussion_r88649329
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java
---
@@ -151,6 +176,15 @@ private SerializationResult getSerializationResult() {
return SerializationResult.PARTIAL_RECORD_MEMORY_SEGMENT_FULL;
}
+ /**
+ * Gets the currently set target buffer and sets its size to the actual
+ * number of written bytes.
+ *
+ * After calling this method, a new target buffer is required to
continue
+ * writing (see {@link #setNextBuffer(Buffer)}).
+ *
+ * @return the target buffer that was used
+ */
--- End diff --
Shouldn't these javadocs be added to the RecordSerializer interface
instead? (the same applies to other implemented methods)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
