MartijnVisser commented on code in PR #24271:
URL: https://github.com/apache/flink/pull/24271#discussion_r1479341371
##########
docs/setup_docs.sh:
##########
@@ -36,24 +36,34 @@ function integrate_connector_docs {
}
+SKIP_INTEGRATE_CONNECTOR_DOCS=false
+for arg in "$@"; do
+ if [ "$arg" == "--skip-integrate-connector-docs" ]; then
+ SKIP_INTEGRATE_CONNECTOR_DOCS=true
+ break
+ fi
+done
+
# Integrate the connector documentation
+if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then
+ echo "Integrate connector docs"
+ rm -rf themes/connectors/*
+ rm -rf tmp
+ mkdir tmp
+ cd tmp
+
+ integrate_connector_docs elasticsearch v3.0
+ integrate_connector_docs aws v4.2
+ integrate_connector_docs cassandra v3.1
+ integrate_connector_docs pulsar v4.0
+ integrate_connector_docs jdbc v3.1
+ integrate_connector_docs rabbitmq v3.0
+ integrate_connector_docs gcp-pubsub v3.0
+ integrate_connector_docs mongodb v1.0
+ integrate_connector_docs opensearch v1.1
+ integrate_connector_docs kafka v3.0
+ integrate_connector_docs hbase v3.0
Review Comment:
Have you checked if the Hugo build fails if nothing has been cloned yet from
the external connectors, but the `skip_integrate_connector_docs` is being used?
Does the Hugo build fail at that point? If not, then we should be OK. If it
fails, it might make sense to first check if the repos have already been cloned
and else throw a warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
