hackergin commented on code in PR #24235:
URL: https://github.com/apache/flink/pull/24235#discussion_r1479450586
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -158,16 +160,17 @@
* Default implementation of {@link SqlValidator}, the class was copied over
because of
* CALCITE-4554.
*
- * <p>Lines 1958 ~ 1978, Flink improves error message for functions without
appropriate arguments in
+ * <p>Lines 1961 ~ 1981, Flink improves error message for functions without
appropriate arguments in
* handleUnresolvedFunction at {@link
SqlValidatorImpl#handleUnresolvedFunction}.
*
- * <p>Lines 3736 ~ 3740, Flink improves Optimize the retrieval of sub-operands
in SqlCall when using
- * NamedParameters at {@link SqlValidatorImpl#checkRollUp}.
+ * <p>Lines 3739 ~ 3743, 6333 ~ 6339, Flink improves validating the SqlCall
that uses named
+ * parameters, rearrange the order of sub-operands, and fill in missing
operands with the default
Review Comment:
Thank you for the suggestion. I have created the corresponding JIRA ticket.
You can find it at https://issues.apache.org/jira/browse/CALCITE-6245.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
