[
https://issues.apache.org/jira/browse/FLINK-34405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815277#comment-17815277
]
Matthias Pohl commented on FLINK-34405:
---------------------------------------
Looks like the issue is not a blocker. My suspicion is that the {{sleep}} in
[AbstractOuterJoinTaskTest#testCancelOuterJoinTaskWhileSort2:424|https://github.com/apache/flink/blob/ac61e83dad8ea7d0fc91ad98315b2987275586dd/flink-runtime/src/test/java/org/apache/flink/runtime/operators/AbstractOuterJoinTaskTest.java#L424]
is just not properly set which allowed the subsequent
[taskRunner.interrupt()|https://github.com/apache/flink/blob/ac61e83dad8ea7d0fc91ad98315b2987275586dd/flink-runtime/src/test/java/org/apache/flink/runtime/operators/AbstractOuterJoinTaskTest.java#L427]
be called too early (while {{RightOuterJoinDriver#prepare}} is still not
finished.
We need to refactor the test to rely on futures instead of {{Thread#sleep}} to
fix this.
> RightOuterJoinTaskTest#testCancelOuterJoinTaskWhileSort2 fails due to an
> interruption of the RightOuterJoinDriver#prepare method
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-34405
> URL: https://issues.apache.org/jira/browse/FLINK-34405
> Project: Flink
> Issue Type: Bug
> Components: API / Core
> Affects Versions: 1.19.0, 1.20.0
> Reporter: Matthias Pohl
> Priority: Critical
> Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=57357&view=logs&j=d89de3df-4600-5585-dadc-9bbc9a5e661c&t=be5a4b15-4b23-56b1-7582-795f58a645a2&l=9027
> {code}
> Feb 07 03:20:16 03:20:16.223 [ERROR] Failures:
> Feb 07 03:20:16 03:20:16.223 [ERROR]
> org.apache.flink.runtime.operators.RightOuterJoinTaskTest.testCancelOuterJoinTaskWhileSort2
> Feb 07 03:20:16 03:20:16.223 [ERROR] Run 1:
> RightOuterJoinTaskTest>AbstractOuterJoinTaskTest.testCancelOuterJoinTaskWhileSort2:435
>
> Feb 07 03:20:16 expected:
> Feb 07 03:20:16 null
> Feb 07 03:20:16 but was:
> Feb 07 03:20:16 java.lang.Exception: The data preparation caused an error:
> Interrupted
> Feb 07 03:20:16 at
> org.apache.flink.runtime.operators.testutils.BinaryOperatorTestBase.testDriverInternal(BinaryOperatorTestBase.java:209)
> Feb 07 03:20:16 at
> org.apache.flink.runtime.operators.testutils.BinaryOperatorTestBase.testDriver(BinaryOperatorTestBase.java:189)
> Feb 07 03:20:16 at
> org.apache.flink.runtime.operators.AbstractOuterJoinTaskTest.access$100(AbstractOuterJoinTaskTest.java:48)
> Feb 07 03:20:16 ...(1 remaining lines not displayed - this can be
> changed with Assertions.setMaxStackTraceElementsDisplayed)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
