Jiabao-Sun commented on PR #84: URL: https://github.com/apache/flink-connector-kafka/pull/84#issuecomment-1933305498
Thanks @mas-chen for the review. The main reason for this PR is in version 1.19, due to the introduction of WriterInitContext by FLINK-33973. In terms of code changes, KafkaSink.createWriter is used to ensure that TestSinkInitContext can correctly create KafkaWriter regardless of whether it inherits from WriterInitContext or Sink.InitContext. https://github.com/apache/flink/blob/1b95b191922829fd8e7a76e5c9d8de68bb57ae7d/flink-core/src/main/java/org/apache/flink/api/connector/sink2/Sink.java#L66-L78 https://github.com/apache/flink/pull/24180/files#r1467200868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
