xuyangzhong opened a new pull request, #24289: URL: https://github.com/apache/flink/pull/24289
## What is the purpose of the change The Top3 function emits a tuple of (entry.getKey, entry.getKey) see [UserDefinedTableAggFunctions.scala#L127](https://github.com/apache/flink/blob/907d0f32126b9f8acfc80f3f4098e71cb37f0e37/flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/UserDefinedTableAggFunctions.scala#L127), which is peculiar. Meanwhile, consider getting the scala-free goal; it's time to migrate this class to the `JavaUserDefinedTableAggFunctions`, and revisit the implementation. ## Brief change log - *Fix peculiar logic about Top3, Top3WithMapViewAccum and Top3WithRetractInputAcc used for test* - *Move all udx in UserDefinedTableAggFunctions to JavaUserDefinedTableAggFunctions* ## Verifying this change Existent tests can cover these changes. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
