[ 
https://issues.apache.org/jira/browse/FLINK-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677736#comment-15677736
 ] 

ASF GitHub Bot commented on FLINK-4288:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2511#discussion_r88737674
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkSchema.scala
 ---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.table
    +
    +import java.util
    +
    +import org.apache.calcite.jdbc.CalciteSchema
    +import org.apache.calcite.jdbc.CalciteSchema.TableEntry
    +import org.apache.calcite.schema
    +import org.apache.calcite.schema.SchemaPlus
    +
    +/**
    +  * Wraps [[CalciteSchema]] and allows for deleting tables.
    +  */
    +class FlinkSchema {
    --- End diff --
    
    I think the benefit of this wrapper is rather limited.
    Couldn't we just call `schema.tableMap.remove()` in `TableEnvironment`?


> Make it possible to unregister tables
> -------------------------------------
>
>                 Key: FLINK-4288
>                 URL: https://issues.apache.org/jira/browse/FLINK-4288
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>
> Table names can not be changed yet. After registration you can not modify the 
> table behind a table name. Maybe this behavior is too restrictive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to