zentol commented on code in PR #24300:
URL: https://github.com/apache/flink/pull/24300#discussion_r1485936485
##########
pom.xml:
##########
@@ -175,6 +175,7 @@ under the License.
<orc.version>1.5.6</orc.version>
<japicmp.referenceVersion>1.18.0</japicmp.referenceVersion>
<japicmp.outputDir>tools/japicmp-output</japicmp.outputDir>
+ <spotless.skip>false</spotless.skip>
Review Comment:
we could of course update them to use `spotless.check.skip`, but at least I
`expected` `spotless.skip` to be the property to use.
##########
pom.xml:
##########
@@ -175,6 +175,7 @@ under the License.
<orc.version>1.5.6</orc.version>
<japicmp.referenceVersion>1.18.0</japicmp.referenceVersion>
<japicmp.outputDir>tools/japicmp-output</japicmp.outputDir>
+ <spotless.skip>false</spotless.skip>
Review Comment:
we could of course update them to use `spotless.check.skip`, but at least I
_expected_ `spotless.skip` to be the property to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
