nicusX commented on code in PR #1:
URL: 
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1486607342


##########
example-datastream-job/README.md:
##########
@@ -0,0 +1,22 @@
+## Example  job using Prometheus Sink connector with DataStream API
+
+Sample application demonstrating the usage of Prometheus Sink Connector with 
DataStream API.
+
+The example demonstrates how to write to a generic, unauthenticated Prometheus 
remote-write URL, and optionally how to use the Amazon Managed Prometheus 
request signer.
+
+It generates random dummy Memory and CPU metrics from a number of instances, 
and writes them to Prometheus.
+
+### Configuration
+
+The application expects these parameters, via command line:
+
+* `--prometheusRemoteWriteUrl <URL>`: the Prometheus remote-write URL to target
+* `--awsRegion <region>`: (optional) if specified, it configures the Amazon 
Managed Prometheus request signer for a workspace in this Region
+* `--webUI`: (optional, for local development only) enables Flink Web UI, with 
flame graphs, for local development

Review Comment:
   I don't think that would be any useful.
   The way you pass parameters depends on your deployment.
   And if you are running locally in your IDE, it depends on your IDE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to