rkhachatryan commented on code in PR #24292:
URL: https://github.com/apache/flink/pull/24292#discussion_r1486799769
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java:
##########
@@ -1266,15 +1282,21 @@ public CompletableFuture<Acknowledge> freeSlot(
@Override
public void freeInactiveSlots(JobID jobId, Time timeout) {
- log.debug("Freeing inactive slots for job {}.", jobId);
+ MdcUtils.addJobID(jobId);
Review Comment:
It wouldn't work for all cases because sometimes we need to extract job ID
from the argument or TM state.
(And also that would be much less readable IMO)
edit: it also removes the logger after the execution completely which is not
what we want for non-test loggers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
