ferenc-csaky commented on code in PR #24303:
URL: https://github.com/apache/flink/pull/24303#discussion_r1487526406
##########
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesClusterDescriptorTest.java:
##########
@@ -86,7 +86,8 @@ public FlinkKubeClient fromConfiguration(
server.createClient().inNamespace(NAMESPACE),
Executors.newDirectExecutorService());
}
- });
+ },
+ config -> {});
Review Comment:
It is a valid point IMO, during the impl I was thinking about wiring a
`KubernetesArtifactUploader.NO_OP` into `KubernetesClusterDescriptor` according
to the `local-upload-enabled` config option, but I thought it would be better
to encapsulate all this logic into the uploader so
`KubernetesClusterDescriptor` won't manage any upload related logic actively,
hence I did not added that `NO_OP` impl, cause in tests there are a lot of
other in place no-op usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
