mxm commented on code in PR #776: URL: https://github.com/apache/flink-kubernetes-operator/pull/776#discussion_r1489321926
########## docs/content/docs/custom-resource/overview.md: ########## @@ -216,6 +216,38 @@ Alternatively, if you use helm to install flink-kubernetes-operator, it allows y - Last-state upgradeMode is currently not supported for FlinkSessionJobs +## Flink SQL Jobs Review Comment: I think we should avoid copying anything over from https://github.com/apache/flink-kubernetes-operator/tree/main/examples/. Instead, we can extract the above linked examples section to a dedicated page and add any extra information we find useful. ########## docs/content/docs/custom-resource/overview.md: ########## @@ -216,6 +216,38 @@ Alternatively, if you use helm to install flink-kubernetes-operator, it allows y - Last-state upgradeMode is currently not supported for FlinkSessionJobs +## Flink SQL Jobs Review Comment: Taking another look, this might not be the best place to add this information because it's an overview page and the steps are quite detailed. There is already a section mentioning the examples: https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/concepts/overview/#built-in-examples How about creating a dedicated Examples page? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
