gyfora commented on code in PR #774:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489401020
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java:
##########
@@ -356,13 +421,13 @@ public static double getAverage(
?
collectedMetrics.getVertexMetrics().get(jobVertexId)
: collectedMetrics.getGlobalMetrics();
double num = metrics.getOrDefault(metric, Double.NaN);
- if (Double.isNaN(num)) {
- continue;
- }
if (Double.isInfinite(num)) {
anyInfinite = true;
continue;
}
+ if (Double.isNaN(num)) {
+ continue;
+ }
Review Comment:
I will revert this, I made some changes that I later removed, not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
