gyfora commented on code in PR #762:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1489489638
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -250,6 +252,39 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.withDescription(
"Max allowed percentage of heap usage during
scaling operations. Autoscaling will be paused if the heap usage exceeds this
threshold.");
+ public static final ConfigOption<Boolean> MEMORY_TUNING_ENABLED =
+ autoScalerConfig("memory.tuning.enabled")
+ .booleanType()
+ .defaultValue(false)
+
.withFallbackKeys(oldOperatorConfigKey("memory.tuning.enabled"))
+ .withDescription(
+ "If enabled, the initial amount of memory
specified for TaskManagers will be reduced according to the observed needs.");
+
+ public static final ConfigOption<MemoryTuning.HeapTuningTarget>
MEMORY_TUNING_HEAP_TARGET =
+ autoScalerConfig("memory.tuning.heap.target-usage")
Review Comment:
This config key sounds similar to target utilisation but works a completely
different way, but I don't really have a better suggestion :)
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -250,6 +252,39 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.withDescription(
"Max allowed percentage of heap usage during
scaling operations. Autoscaling will be paused if the heap usage exceeds this
threshold.");
+ public static final ConfigOption<Boolean> MEMORY_TUNING_ENABLED =
+ autoScalerConfig("memory.tuning.enabled")
+ .booleanType()
+ .defaultValue(false)
+
.withFallbackKeys(oldOperatorConfigKey("memory.tuning.enabled"))
+ .withDescription(
+ "If enabled, the initial amount of memory
specified for TaskManagers will be reduced according to the observed needs.");
+
+ public static final ConfigOption<MemoryTuning.HeapTuningTarget>
MEMORY_TUNING_HEAP_TARGET =
+ autoScalerConfig("memory.tuning.heap.target-usage")
+ .enumType(MemoryTuning.HeapTuningTarget.class)
+ .defaultValue(MemoryTuning.HeapTuningTarget.AVG)
Review Comment:
If Max is more conservative should that be the default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
