hanyuzheng7 commented on code in PR #23173: URL: https://github.com/apache/flink/pull/23173#discussion_r1492752435
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ########## @@ -391,6 +391,16 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL) .internal() .build(); + public static final BuiltInFunctionDefinition ARRAY_EXCEPT = + BuiltInFunctionDefinition.newBuilder() + .name("ARRAY_EXCEPT") + .kind(SCALAR) + .inputTypeStrategy(commonArrayType(2)) + .outputTypeStrategy(nullableIfArgs(COMMON)) Review Comment: fter conducting research, it appears that most databases return NULL if any input array is NULL. Therefore, I believe we can maintain our original output strategy. https://github.com/apache/flink/pull/23173#discussion_r1492749138 ########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ########## @@ -391,6 +391,16 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL) .internal() .build(); + public static final BuiltInFunctionDefinition ARRAY_EXCEPT = + BuiltInFunctionDefinition.newBuilder() + .name("ARRAY_EXCEPT") + .kind(SCALAR) + .inputTypeStrategy(commonArrayType(2)) + .outputTypeStrategy(nullableIfArgs(COMMON)) Review Comment: After conducting research, it appears that most databases return NULL if any input array is NULL. Therefore, I believe we can maintain our original output strategy. https://github.com/apache/flink/pull/23173#discussion_r1492749138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org