Jiabao-Sun commented on code in PR #23960:
URL: https://github.com/apache/flink/pull/23960#discussion_r1495969675
##########
flink-core/src/test/java/org/apache/flink/api/common/ExecutionConfigFromConfigurationTest.java:
##########
@@ -20,23 +20,19 @@
import org.apache.flink.configuration.Configuration;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
import java.util.Arrays;
import java.util.Collection;
import java.util.function.BiConsumer;
import java.util.function.Consumer;
import java.util.function.Function;
-import static org.hamcrest.CoreMatchers.equalTo;
-import static org.junit.Assert.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
-@RunWith(Parameterized.class)
Review Comment:
Can we use ParameterizedTestExtension so that we can maintain consistency
with the original style?
```java
package org.apache.flink.api.common;
import org.apache.flink.configuration.Configuration;
import org.apache.flink.testutils.junit.extensions.parameterized.Parameter;
import org.apache.flink.testutils.junit.extensions.parameterized.Parameters;
import
org.apache.flink.testutils.junit.extensions.parameterized.ParameterizedTestExtension;
import org.junit.jupiter.api.TestTemplate;
import org.junit.jupiter.api.extension.ExtendWith;
import java.util.Arrays;
import java.util.Collection;
import java.util.function.BiConsumer;
import java.util.function.Consumer;
import java.util.function.Function;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.junit.Assert.assertThat;
@ExtendWith(ParameterizedTestExtension.class)
class ExecutionConfigFromConfigurationTest {
@Parameters(name = "{0}")
private static Collection<TestSpec> specs() {
return Arrays.asList(
TestSpec.testValue(false)
.whenSetFromFile("pipeline.auto-generate-uids",
"false")
.viaSetter(
booleanSetter(
ExecutionConfig::enableAutoGeneratedUIDs,
ExecutionConfig::disableAutoGeneratedUIDs))
.getterVia(ExecutionConfig::hasAutoGeneratedUIDsEnabled)
.nonDefaultValue(false),
TestSpec.testValue(false)
.whenSetFromFile("pipeline.auto-type-registration",
"false")
.viaSetter(
booleanSetter(
e -> {
throw new
IllegalArgumentException(
"Cannot enable auto type
registration");
},
ExecutionConfig::disableAutoTypeRegistration))
.getterVia(e -> !e.isAutoTypeRegistrationDisabled())
.nonDefaultValue(false),
TestSpec.testValue(120000L)
.whenSetFromFile("pipeline.auto-watermark-interval",
"2 min")
.viaSetter(ExecutionConfig::setAutoWatermarkInterval)
.getterVia(ExecutionConfig::getAutoWatermarkInterval)
.nonDefaultValue(123L),
TestSpec.testValue(ExecutionConfig.ClosureCleanerLevel.TOP_LEVEL)
.whenSetFromFile("pipeline.closure-cleaner-level",
"TOP_LEVEL")
.viaSetter(ExecutionConfig::setClosureCleanerLevel)
.getterVia(ExecutionConfig::getClosureCleanerLevel)
.nonDefaultValue(ExecutionConfig.ClosureCleanerLevel.NONE),
TestSpec.testValue(true)
.whenSetFromFile("pipeline.force-avro", "true")
.viaSetter(
booleanSetter(
(ec) ->
ec.getSerializerConfig().setForceAvro(true),
(ec) ->
ec.getSerializerConfig().setForceAvro(false)))
.getterVia((ec) ->
ec.getSerializerConfig().isForceAvroEnabled())
.nonDefaultValue(true),
TestSpec.testValue(false)
.whenSetFromFile("pipeline.force-kryo", "false")
.viaSetter(
booleanSetter(
(ec) ->
ec.getSerializerConfig().setForceKryo(true),
(ec) ->
ec.getSerializerConfig().setForceKryo(false)))
.getterVia((ec) ->
ec.getSerializerConfig().isForceKryoEnabled())
.nonDefaultValue(false),
TestSpec.testValue(false)
.whenSetFromFile("pipeline.generic-types", "false")
.viaSetter(
booleanSetter(
(ec) ->
ec.getSerializerConfig().setGenericTypes(true),
(ec) ->
ec.getSerializerConfig().setGenericTypes(false)))
.getterVia(
execConfig ->
!execConfig.getSerializerConfig().hasGenericTypesDisabled())
.nonDefaultValue(false),
TestSpec.testValue(getTestGlobalJobParameters())
.whenSetFromFile(
"pipeline.global-job-parameters",
"key1:value1,key2:value2")
.viaSetter(ExecutionConfig::setGlobalJobParameters)
.getterVia(ExecutionConfig::getGlobalJobParameters)
.nonDefaultValue(getOtherTestGlobalJobParameters()),
TestSpec.testValue(64)
.whenSetFromFile("pipeline.max-parallelism", "64")
.viaSetter(ExecutionConfig::setMaxParallelism)
.getterVia(ExecutionConfig::getMaxParallelism)
.nonDefaultValue(13),
TestSpec.testValue(true)
.whenSetFromFile("pipeline.object-reuse", "true")
.viaSetter(
booleanSetter(
ExecutionConfig::enableObjectReuse,
ExecutionConfig::disableObjectReuse))
.getterVia(ExecutionConfig::isObjectReuseEnabled)
.nonDefaultValue(true),
TestSpec.testValue(true)
.whenSetFromFile("execution.checkpointing.snapshot-compression", "true")
.viaSetter(ExecutionConfig::setUseSnapshotCompression)
.getterVia(ExecutionConfig::isUseSnapshotCompression)
.nonDefaultValue(true),
TestSpec.testValue(12)
.whenSetFromFile("parallelism.default", "12")
.viaSetter(ExecutionConfig::setParallelism)
.getterVia(ExecutionConfig::getParallelism)
.nonDefaultValue(21),
TestSpec.testValue(12000L)
.whenSetFromFile("task.cancellation.interval",
"12000")
.viaSetter(ExecutionConfig::setTaskCancellationInterval)
.getterVia(ExecutionConfig::getTaskCancellationInterval)
.nonDefaultValue(21L),
TestSpec.testValue(12100L)
.whenSetFromFile("task.cancellation.timeout",
"12100")
.viaSetter(ExecutionConfig::setTaskCancellationTimeout)
.getterVia(ExecutionConfig::getTaskCancellationTimeout)
.nonDefaultValue(21L),
TestSpec.testValue(12300L)
.whenSetFromFile("metrics.latency.interval", "12300")
.viaSetter(ExecutionConfig::setLatencyTrackingInterval)
.getterVia(ExecutionConfig::getLatencyTrackingInterval)
.nonDefaultValue(21L));
}
@Parameter
private TestSpec spec;
@TestTemplate
void testLoadingFromConfiguration() {
ExecutionConfig configFromSetters = new ExecutionConfig();
ExecutionConfig configFromFile = new ExecutionConfig();
Configuration configuration = new Configuration();
configuration.setString(spec.key, spec.value);
configFromFile.configure(configuration,
ExecutionConfigTest.class.getClassLoader());
spec.setValue(configFromSetters);
spec.assertEqual(configFromFile, configFromSetters);
}
@TestTemplate
void testNotOverridingIfNotSet() {
ExecutionConfig executionConfig = new ExecutionConfig();
spec.setNonDefaultValue(executionConfig);
Configuration configuration = new Configuration();
executionConfig.configure(configuration,
ExecutionConfigTest.class.getClassLoader());
spec.assertEqualNonDefault(executionConfig);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
