echauchot commented on code in PR #38:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/38#discussion_r1499408610
##########
_utils.sh:
##########
@@ -68,4 +68,15 @@ function set_pom_version {
new_version=$1
${MVN} org.codehaus.mojo:versions-maven-plugin:2.8.1:set
-DnewVersion=${new_version} -DgenerateBackupPoms=false --quiet
+}
+
+function is_flink_version_set_in_pom {
+ set +u
+ version=$(${MVN} help:evaluate -Dexpression="flink.version" -q -DforceStdout)
+ if [ -n "${version}" ]; then
Review Comment:
> This isn't quite reliable because it fails if the pom doesn't contain a
reference to flink.version at all (e.g. the Flink repo).
Yes but the script is made for connectors releases only and today
- for the regular connectors: `flink.version` is mandatory
- for connector parent: `flink.version` is used in plugin configuration.
That being said, I agree it is better to harden this to be future proof.
Thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
